Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

separate dependencies #418

Merged
merged 8 commits into from
Jan 31, 2024
Merged

separate dependencies #418

merged 8 commits into from
Jan 31, 2024

Conversation

epwalsh
Copy link
Member

@epwalsh epwalsh commented Jan 31, 2024

No description provided.

@epwalsh epwalsh requested a review from AkshitaB January 31, 2024 01:42
Comment on lines +12 to +15
RUN mkdir olmo && touch olmo/__init__.py && \
pip install --no-cache-dir .[all] && \
pip uninstall -y ai2-olmo && \
rm -rf olmo/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we uninstall?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't actually want the codebase built into these Dockerfiles, just the dependencies

@epwalsh epwalsh merged commit 0e53b33 into main Jan 31, 2024
10 checks passed
@epwalsh epwalsh deleted the epwalsh/dependencies branch January 31, 2024 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants